[Ffmpeg-devel] [PATCH] ac3 decoder

[Michael Niedermayer]

Hi

On Wed, Oct 18, 2006 at 06:34:27AM +0200, Benjamin Larsson wrote:
> Justin Ruggles wrote:
> 
> >[...]
> >
> >The solution I've come up with uses ac3_common.c & ac3_common.h for the
> >bit allocation routines & table initialization.  The alternative would

ok


> >be to either define all the tables as const & set the values instead of
> >calculating at runtime or put table inits in both the encoder and
> >decoder...unless it would be okay to put the initialization in ac3tab.h
> >as static inline (not my favorite choice).  Any advice here?
> >
> >Thanks,
> >Justin
> > 
> >
> 
> Well I would prefer to put all the shareable parts in seperate files 
> that can be included from the main files. 

rejected, this is only ok for speed critical things, otherwise it leads to
duplication of the code in the object files, which is fine if theres
a speed gain, if there none its not


> But it might be an option to 
> put both the decoder and encoder in the same file.

please dont, we already have enough 8000line files
and i really like to have a ffmpeg which people an use on memory starved 
systems (many embeded systems fall in this category) ...

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is