[Ffmpeg-devel] [PATCH] send RTCP Reciever report

[thijsvermeir at telenet.be]

>----- Oorspronkelijk bericht -----
>Van: Michael Niedermayer [mailto:michaelni at gmx.at]
>Verzonden: dinsdag, oktober 24, 2006 12:23 AM
>Aan: 'FFmpeg development discussions and patches'
>Onderwerp: Re: [Ffmpeg-devel] [PATCH] send RTCP Reciever report
>
>Hi
>

Hello again,

Thanks for reviewing the code, I checked your comments and changed the patch where needed.

>[...]
>> +#define USERAGENT "FFMpeg libavformat " LIBAVFORMAT_IDENT
>
>LIBAVFORMAT_IDENT alone should be ok or?
>
>
>[...]
>> @@ -704,6 +706,8 @@
>>      pstrcpy(buf, sizeof(buf), cmd);
>>      snprintf(buf1, sizeof(buf1), "CSeq: %d\r\n", rt->seq);
>>      pstrcat(buf, sizeof(buf), buf1);
>> +    snprintf(buf1, sizeof(buf1), "User-Agent: %s\r\n", USERAGENT);
>> +    pstrcat(buf, sizeof(buf), buf1);

This seems not needed so I dropped it out of this patch.

As an attachment you find a new try for this patch.
I hope it can find a way into the code so that we can add real statistics ( See the reply of Ryan)

Thanks,
Thijs
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rtcp_receiver_report_try2.patch
Type: application/octet-stream
Size: 7709 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20061024/bd5ab0fd/attachment.obj>