[Ffmpeg-devel] Re: Re: Re: mjpeg with trellis quant segaults ... to be expected

Karl H. Beckers karl.h.beckers
Thu Oct 26 19:23:44 CEST 2006

> the indention of the new code is wrong, the patch has random linebreaks
> in the midde (=its malformed and not applyable)
> besides checking for this in the innermost loop is not acceptable
> this can and should be checked during init or trellis quant should be
> changed to support mjpeg

I only sent the diff to highlight the issue not to suggest that this
should be the fix or applied as a patch. I'm also all with you about
adding the feature (though that won't be me ;S), but then, if the encoders
are not required to put a value there (or perhaps they are and mjpeg just
doesn't comply) the code shouldn't rely on it being filled.

Anyway, perhaps the attached bit is more agreeable as a quickfix.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: mpegvideo.c.patch
Type: text/x-patch
Size: 744 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20061026/78095f56/attachment.bin>

More information about the ffmpeg-devel mailing list