[Ffmpeg-devel] [PATCH] optimize ff_eval

[Michael Niedermayer]

Hi

On Fri, Oct 27, 2006 at 05:15:38PM +0200, Oded Shimon wrote:
> On Fri, Oct 27, 2006 at 01:03:49PM +0200, Michael Niedermayer wrote:
> > On Fri, Oct 27, 2006 at 12:25:06PM +0200, Oded Shimon wrote:
> > > Thing is, current version is ~3 times faster for one-shot evals, not to 
> > > mention simpler API and no mallocs. I think AVOption uses eval in one-shot 
> > > cases? Might be a good idea to keep both, it would involve some inevitable 
> > > duplicate code though...
> > 
> > iam against that, a ff_eval() which calles the new parse & eval is enough
> > the small number of cycles during parsing of command line params doesnt
> > matter, all? other cases use the same expression many times
> 
> Should I mark ff_eval2 as deprecated?

hmm, iam not sure ...
leave it for now we can always deprecate it later


> 
> > [...]
> > please use a enum for e->type
> 
> Fixed.
> 
> Commit?

yes after you fix 

[...]
> +        d->type = 0;

e_value (and the other such cases ...)


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is