[Ffmpeg-devel] RTP patches & RFC

Guillaume POIRIER poirierg
Sun Oct 29 12:02:24 CET 2006


Hi,

On 10/29/06, Ryan Martell <rdm4 at martellventures.com> wrote:
>
> On Oct 28, 2006, at 12:09 PM, Guillaume POIRIER wrote:
>
> > Hi,
> >
> > On 10/28/06, Ryan Martell <rdm4 at martellventures.com> wrote:
> >>
> >> On Oct 27, 2006, at 11:56 AM, Ryan Martell wrote:
> >> > On Oct 27, 2006, at 5:53 AM, Michael Niedermayer wrote:
> >> >>> Once those are applied, I'll add the rtp modification patch.
> >>
> >> Here's the rtp modification patch...
> >
> > Could you please detail a little bit what this patch is supposed to
> > do? I'd need that to have a commit message that actually means
> > something.
>
> This patch fixes more dynamic protocol stuff, needed by the
> forthcoming h264 streaming patch.  (Minor additions to give more
> information to the dynamic protocol handlers, and a slight
> rearrangement of code.
>
> > I also note that you haven't put any comment before function
> > :rtsp_next_attr_and_value()
>
> Fixed; it doesn't really do anything right now; it's going to be used
> from the function below it in the next patch, as well as be used by
> rtp_h264.c, which is forthcoming.

Patch applied, after I removed the tabs and trailing spaces from your
patch. This is REALLY annoying. Please do smth about it, or else I
guess I'm just gonna ignore all your future patches (I know I said
that already, it's just that I don't want to have to come to the point
where I actually do it).

Guillaume
-- 
With DADVSI (http://en.wikipedia.org/wiki/DADVSI), France finally has
a lead on USA on selling out individuals right to corporations!
Vive la France!




More information about the ffmpeg-devel mailing list