[Ffmpeg-devel] [PATCH] MingW RTSP support

François Revol revol
Mon Oct 30 22:56:49 CET 2006


> > #include "avformat.h"
> > #include <unistd.h>
> > #include <sys/types.h>
> > #include <sys/time.h>
> > #include <fcntl.h>
> > #if !defined(__MINGW32__) && !defined(__BEOS__)

^^^That's plain wrong.
BeOS does have socket.h, and even arpa/inet.h, but only for BONE (post 
R5, but I guess we can probably drop R5 support now that Haiku is 
coming).

> > #include <sys/socket.h>
> > #include <netinet/in.h>
> > #include <netdb.h>
> > #include <arpa/inet.h>
> > #endif
> > 
> > I think this is a nice comprimise.. the code looks cleaner now and
> > both broken OS's compile...
> > 
> > the only problem with BeOS (which I guess doesn't matter anyway) is
> > SO_ERROR doesn't exist so without commenting or #defining out, it 
> > won't
> > compile anyway... maybe no one even uses ffmpeg under BeOS so no 
> > one
> > noticed?

I do.
Just I don't have the time to maintain it atm.
Just in case someone screw up let me remind you I do kung fu :D

> I've looked at this patch again, here is a slightly cleaned-up 
> version.
> Is this OK to commit?

Probably not, but I guess I'll have to fix other stuff again next time 
I try a build anyway.

Fran?ois.




More information about the ffmpeg-devel mailing list