[Ffmpeg-devel] [PATCH] BMP encoder
Tue Oct 31 14:27:10 CET 2006
Michael Niedermayer wrote:
> On Mon, Oct 30, 2006 at 06:50:35PM +0100, Michel Bardiaux wrote:
>> Note that I have some doubts about that code: it seems to assume that IF
>> the compiler is not gcc THEN alignment is not an issue for 16 or 32 bits
>> store. That is clearly wrong. Is dsputil.h supposed to be included by
>> client code?
> not really, at least ST*() isnt supposed to be used ...
Well, they'll be moved anyway, see other message. But I've just
remembered that in some app I call imgconvert directly, no codec or
whatever involved, and for that to work I had to call dsputil_init
directly, and for that include dsputil.h.
Move the prototype for dsputil_init to avcodec.h? Or call it from
imgconvert (and maybe other places)?
>> If not, then why the 'else not GNUC clause?
> because we do support a few other compilers ...
But if dsputil.h is NOT supposed to be exported, then it has only to
Besides, the non-gcc part is simply wrong: it assumes a naive unaligned
store will work, and that's false on many architectures.
T +32  2 790 29 41
F +32  2 790 29 02
E mailto:mbardiaux at mediaxim.be
Vorstlaan 191 Boulevard du Souverain
Brussel 1160 Bruxelles
More information about the ffmpeg-devel