[Ffmpeg-devel] [PATCH] RTCP valid receiver statistics....
Tue Oct 31 20:34:42 CET 2006
On Mon, Oct 30, 2006 at 05:43:58PM -0600, Ryan Martell wrote:
> Here's my patch to get the valid statistics for the RTCP receiver
> report. This was basically taken verbatim from RFC 1889.
> I carefully went over it for trailing whitespace; the only tabs are
> in the svn diff generated header (before the revision numbers) which
> I suspect are okay.
> Note, I also added the url_write() return value check in the #ifdef'd
> DEBUG case. This is because (for me) this is returning -2, and my
> server is timing me out. This is a different bug, and I was asking
> on the other thread if this is just my problem or a general issue.
> +* called on parse open packet
> + */
the * should be 1 space farthe to the right :)
> +// returns 1 if we should handle this packet.
> +static int rtp_valid_packet_in_sequence(RTPStatistics *s, uint16_t seq)
comment isnt doxygen compatible
> +#if 0
> +* This function is currently unused; without a valid local ntp time, I don't see how we could calculate the
> +* difference between the arrival and sent timestamp. As a result, the jitter and transit statistics values
> +* never change. I left this in in case someone else can see a way. (rdm)
the system time should be used
> - url_write(s->rtp_ctx, buf, len);
> - av_free(buf);
> + result= url_write(s->rtp_ctx, buf, len);
> +#if defined(DEBUG)
> + printf("result from url_write: %d\n", result);
> + av_free(buf);
indention is slightly inconsistant
> +#if defined(DEBUG) && 0
> -#if defined(DEBUG) || 1
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is
More information about the ffmpeg-devel