[Ffmpeg-devel] [PATCH] WAVE and AIFF packets timestamps

[Michael Niedermayer]

Hi

On Tue, Sep 05, 2006 at 03:08:12PM -0400, Patrick Guimond wrote:
[...]
> >> #ifdef CONFIG_MUXERS
> >>-typedef struct {
> >>-    offset_t form;
> >>-    offset_t frames;
> >>-    offset_t ssnd;
> >>-} AIFFOutputContext;
> >>-
> >
> >this is mostly cosmetic and rejected, this can be done with far fewer
> >changed lines
> >
> 
> Modified patch attached
[...]
> +void av_cbr_set_ts(AVPacket *pkt, AVStream *st, int64_t st_start_pos)
> +{
> +    /* Div by 0 check */
> +    if (!st->codec->block_align)
> +        return;

when does this fail? if never than the check should be removed


> +
> +    if (pkt->pts == AV_NOPTS_VALUE) {

same here, is there any case where pts is not AV_NOPTS_VALUE?


> +        assert(pkt->pos >= st_start_pos);
> +        pkt->pts = (pkt->pos - st_start_pos)/st->codec->block_align -
> +                    st->start_time;
> +    }
> +
> +    if (!pkt->duration)

and here


[...]
> +typedef struct {
> +    offset_t data_pos;

how does this differ from AVFormatContext.data_offset?


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is