[Ffmpeg-devel] [PATCH] Remove unused AVOption helper functions

Panagiotis Issaris takis.issaris
Thu Sep 7 17:06:25 CEST 2006


Op donderdag 7 september 2006 16:58, schreef Panagiotis Issaris:
> The functions av_set_int, av_set_q, av_get_q and av_get_string are not used
> at all.
> The patch attached removes them, in case they are unnecessary remains and
> not part of some new API that has not been used yet, but is supposed to be
> used in the near future.
And just to clear up the obvious, ofcourse I am aware that it looks prettier
for an API to have the setters and getters in pairs. But, it seems weird to
me that av_set_int f.e. is not used at all, while there are AVOptions which
are of type FF_OPT_TYPE_INT. Same with the av_get_string/FF_OPT_TYPE_STRING
and av_(get|set)_q/FF_OPT_TYPE_RATIONAL.

To me it looks like the functions do not match the need, as they appear to
not even be necessary and used. 

Or ofcourse, the functions appeared _after_ the code which could use them
was written :)

With friendly regards,

More information about the ffmpeg-devel mailing list