[Ffmpeg-devel] [PATCH] Make avformat_get_context_defaults static

Matti Hamalainen mhamalai
Fri Sep 8 12:59:53 CEST 2006

On Fri, 8 Sep 2006, Michael Niedermayer wrote:

> shouldnt it be
> LIBAVCODEC_VERSION_INT >= ((52<<16)+(0<<8)+0)

Is there some specific reason, why there is no macro
used for this, in order to avoid similar mistakes?

#define MKVERSION(a,b,c) ((a)<<16+(b)<<8+(c))

or similar?

Of course it's a pretty simple element, but the same
things are repeated through the code, a macro might
simplify potential future changes.

] ccr/TNSP^DKD^pWp :: ccr(at)tnsp(dot)org :: http://ccr.tnsp.org/
] Fingerprint: 0466 95ED 96DF 3701 C71D   D62D 10A6 28A6 1374 C112

More information about the ffmpeg-devel mailing list