[Ffmpeg-devel] [PATCH 2/2] Use and set sane AVOption defaults

Panagiotis Issaris takis.issaris
Fri Sep 8 16:41:12 CEST 2006


Op vrijdag 8 september 2006 15:26, schreef Panagiotis Issaris:
> The attached patch lets probesize actually be set by the AVOption default value. And changes
> the track default value be zero instead of 1, so that it will not get written unless
> actually specified.
>  utils.c |    7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> With friendly regards,
> Takis
The updated version of this patch lets the defaults for the AVOptions actually be set by 
the AVOption default value. All regression tests succeeded after applying this test.

 libavcodec/utils.c  |  100 +++++++++++++++-------------------------------------
 libavformat/utils.c |    7 +--
 2 files changed, 32 insertions(+), 75 deletions(-)

I will send another patch removing duplicate options/parameters from ffmpeg.c. I do not
really know how to handle cases such as "bitrate" and "b". If I drop b, the commandline
will change, which will make many people unhappy (including myself :) ). If I drop
bitrate, applications using AVOptions will stop working (Does MPlayer use AVOption options[]
array?). Therefore, I will keep those duplicate for now, until someone sees a nice solution.

With friendly regards,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pi-20060908T163336-set_sane_default_avoptions.diff
Type: text/x-diff
Size: 17225 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060908/1a45b81b/attachment.diff>

More information about the ffmpeg-devel mailing list