[Ffmpeg-devel] privatizing FifoBuffer into libavutil

Michael Niedermayer michaelni
Sun Sep 10 12:54:44 CEST 2006


On Sat, Sep 09, 2006 at 10:49:50PM -0700, Roman Shaposhnik wrote:
> Guys,
> attached is a pretty trivial move of FifoBuffer functionality
> from libavformat/avformat.h and libavformat/util.c into
> libavutil/fifo.[ch]. Please let me know if that's the best
> way to privatize FifoBuffer.
> Thanks,
> Roman.
> P.S. The only caveat here is an implicit put_buffer declaration
> in fifo.c

i think fifo.* should stay in libavformat for now
moving it to libavutil would at absolute minimum require
* av_ prefixes
* no dependancy on libavformat (put_buffer()) -> put_fifo() must not be moved
  to libavutil
* no dependancy on libavcodec (dunno if there is any...)
* the rptr and wptr arguments should be removed as they are never used and
* the version number of libavutil has to be increased

also the move should be done with
svn cp libavformat/utils.c libavformat/fifo.c so that no history is lost

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is

More information about the ffmpeg-devel mailing list