[Ffmpeg-devel] [PATCH 1/2] Enable usage of AVOption default value
Sun Sep 10 22:23:04 CEST 2006
Guillaume POIRIER a ?crit :
> On 9/9/06, Michael Niedermayer <michaelni at gmx.at> wrote:
>> On Sat, Sep 09, 2006 at 12:34:22PM +0200, Panagiotis Issaris wrote:
>> > Hi,
>> > On za, 2006-09-09 at 10:29 +0200, Panagiotis Issaris wrote:
>> > > On za, 2006-09-09 at 00:21 +0200, Aurelien Jacobs wrote:
>> > > > [...]
>> > > > Any reason why you implemented this as a macro instead of a
>> function ?
>> > > Ah! You are absolutely right! In fact, I _had_ a reason during the
>> > > writing of the patch... but it is gone now.
>> > > [...]
>> > > After this, I finally got how flags in AVOption worked, and rewrote
>> > > the flag handling of the patch, so in fact the reason for writing
>> it as
>> > > a macro was gone... I will turn it into a function ASAP and resend a
>> > > patch.
>> > Attached to this e-mail you'll find the updated patch. Regression tests
>> > passed fine on my system.
>> looks ok
> Sorry, I can't manage to get this patch to apply cleanly, it complains
> about tabs and whitespaces problems, which I fixed manualy, but there
> somehow seem to still be some.
Well, now applied. Seems like it's about time to go to bed.
More information about the ffmpeg-devel