[Ffmpeg-devel] [PATCH] drawtext.c: 03 use fixed point in color conversion

Gustavo Sverzut Barbieri barbieri
Mon Sep 11 05:26:06 CEST 2006


On 9/11/06, Rich Felker <dalias at aerifal.cx> wrote:
> On Sun, Sep 10, 2006 at 08:13:44PM +0100, M?ns Rullg?rd wrote:
> > "Gustavo Sverzut Barbieri" <barbieri at gmail.com> writes:
> >
> > > On 9/10/06, M?ns Rullg?rd <mru at inprovide.com> wrote:
> > >> "Gustavo Sverzut Barbieri" <barbieri at gmail.com> writes:
> > >>
> > >> > This does fixed point conversion from RGB to YUV, as suggested here before.
> > >>
> > >> Are there not colorspace conversion functions elsewhere already?
> > >
> > > This code is copied from libavcodec/imgconvert.c, I couldn't find it
> > > anywhere I could just include and use.
> >
> > Rather than blindly replicate code all over the place, it is better to
> > propose exporting such functionality when a need for it is seen.
>
> There might be some issues with dynamic linking and availability of
> symbols from the main program...?

it could be done as a static inline defined in some header or even
just a macro. maybe libavutil/color_transformations.h ?

-- 
Gustavo Sverzut Barbieri
--------------------------------------
Jabber: barbieri at gmail.com
   MSN: barbieri at gmail.com
  ICQ#: 17249123
 Skype: gsbarbieri
Mobile: +55 (81) 9927 0010
 Phone:  +1 (347) 624 6296; 08122692 at sip.stanaphone.com
   GPG: 0xB640E1A2 @ wwwkeys.pgp.net




More information about the ffmpeg-devel mailing list