[Ffmpeg-devel] privatizing FifoBuffer into libavutil

Michael Niedermayer michaelni
Thu Sep 14 08:49:19 CEST 2006


On Wed, Sep 13, 2006 at 09:14:06PM -0700, Roman Shaposhnik wrote:
> > iam also against the name fifo_transfer() as its not obvious if its a read
> > or write
> > except that i like the idea
> > maybe a 
> > fifo_read(f, size, put_buffer, pb);
> > and
> > fifo_read(f, size, NULL, buf); 
> > for the memcpy()
> > 
> > would be one possibility
>   indeed. but pushing this complexity onto consumer might not
> be the best case scenario (it sort of strikes me as 
> exposing the rptr which we agree we shouldn't do it
> and also the NULL doesn't really hint at memcpy() at any way). 
> So how about if I leave fifo_read as it is, but instead of 
> a put_buffer would introduce the generic read (I can even call it
> 'fifo_generic_read'). Internally we might actually have
> the common "body" implementing both of them but at the
> API level there'll be two: fifo_read and fifo_generic_read.


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is

More information about the ffmpeg-devel mailing list