[Ffmpeg-devel] [PATCH] AVOption defaults sync
Thu Sep 14 15:39:51 CEST 2006
Op donderdag 14 september 2006 14:56, schreef Panagiotis Issaris:
> Op dinsdag 12 september 2006 22:09, schreef Michael Niedermayer:
> > > The attached patch synchronizes the defaults specified in the AVOptions array
> > > to the defaults specified in the ffmpeg.c global static variabels. I took the
> > > ones specified in ffmpeg.c as the new ones for AVOptions, as this preserves the
> > > current behavior. Regression tests pass.
> > looks ok though i think that we should eventually change the default of
> > 12frame gop and 200kbit its probably not what most users would want
> Does the "eventually" imply that I can commit the patch as is, and
> that the defaults can be modified in a follow-up patch?
I just figured that _changing_ the defaults, might cause the regression
tests to fail as the unspecified parameters might be different. So, IMHO
it would be better to commit the defaults as they are first, so that if
I hand in a patch which removes the equivalent options from OptionDef
in ffmpeg.c the regression tests will not fail.
> If so, would 800kbit and 15 frame GOP be more in line with what users
> want? Or should I post to ffmpeg-users and see what is being most
> commonly used? :)
In fact, the default options in the AVOptions struct which were not being
used were 800kbit and a 50 frame GOP.
With friendly regards,
More information about the ffmpeg-devel