[Ffmpeg-devel] [PATCH] Add kibi, mibi and gibi support

Panagiotis Issaris takis.issaris
Sat Sep 16 10:13:17 CEST 2006


On za, 2006-09-16 at 09:56 +0200, Panagiotis Issaris wrote:
> Hi,
> The attached patch adds support for the "ki", "Mi" and "Gi" postfixes to
> the AVOption option parsing code. I do know that this in fact is
> incorrect, as the official SI standard uses "Ki" instead of "ki" "for
> consistency reasons" [1]. 
> I was wondering how to solve this? Should I just make the kilo case
> insensitive thus allow both 'k' and 'K' for both? Or make all of them
> case insensitive? What about 'B' then? I had the initial intention to
> have 'B' stand for "byte" and 'b' for "bit" with "" being a shorthand
> for 'b'. If case sensitivity would be removed, both "b" and "B" would
> stand for "byte" (in the current implementation).
>  opt.c |   20 +++++++++++++-------
>  1 files changed, 13 insertions(+), 7 deletions(-)
This patch appears to break regression tests. Sending a fix in a second.

With friendly regards,

More information about the ffmpeg-devel mailing list