[Ffmpeg-devel] [PATCH] Remove "bufsize" OptionDef option

Panagiotis Issaris takis.issaris
Mon Sep 18 16:14:35 CEST 2006


Hi,

Op zaterdag 16 september 2006 01:11, schreef Michael Niedermayer:
> On Sat, Sep 16, 2006 at 12:44:48AM +0200, Panagiotis Issaris wrote:
> > The attached patch removes the "bufsize" OptionDef option from the
> > ffmpeg.c file. The equally named "bufsize" AVOption takes over its
> > function and this occurs transparantly with the exception of the
> > parameter unit change. Regression tests succeed.
> > 
> > So, this is yet another case where the unit of a commandline unit is
> > changed, this time from from kilobytes to bits. Using the postfix "kB"
> > eases the situation:
> > * Before this patch:
> >     ffmpeg -i src.ext -bufsize 224 dst.ext
> > * After this patch:
> >     ffmpeg -i src.ext -bufsize 224kB dst.ext
> 
> no this is not the same theres a 1000/1024 difference
Fixed by the kibi patch.

The attached patch removes the "bufsize" OptionDef option from the
ffmpeg.c file. The equally named "bufsize" AVOption takes over its
function and this occurs transparantly with the exception of the
parameter unit change. Regression tests succeed.

So, this is yet another case where the unit of a commandline unit is
changed, this time from from kilobytes to bits. Using the postfix "KiB"
eases the situation:
* Before this patch:
? ? ffmpeg -i src.ext -bufsize 224 dst.ext
* After this patch:
? ? ffmpeg -i src.ext -bufsize 224KiB dst.ext

 doc/ffmpeg-doc.texi |    2 +-
 ffmpeg.c            |   17 ++++-------------
 2 files changed, 5 insertions(+), 14 deletions(-)

This is the same patch as send before, updated to the current SVN 
source code.

With friendly regards,
Takis
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pi-20060918T150456-ffmpeg-remove_bufsize_option.diff
Type: text/x-diff
Size: 3575 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20060918/c98f5ad2/attachment.diff>



More information about the ffmpeg-devel mailing list