[Ffmpeg-devel] [PATCH] Staticising mpeg12data header

Måns Rullgård mru
Tue Sep 19 18:54:41 CEST 2006

Rich Felker said:
> On Tue, Sep 19, 2006 at 11:46:06AM +0200, Michael Niedermayer wrote:
>> Hi
>> On Tue, Sep 19, 2006 at 09:24:17AM +0200, Diego 'Flameeyes' Petten? wrote:
>> > Working on getting the visibility support working, I've prepared the
>> attached
>> > patch. It makes all the tables in mpeg12data.h header static, and includes
>> it
>> > where they are used, rather than using it as exported, this way it avoids
>> an
>> > interdependency between libavutil and libavformat and removes the symbols
>> > from the exported ABI (before they were exported but not declared in the
>> > installed headers anyway).
>> >
>> > Hope this is acceptable.
>> no its not, it duplicates the tables in the binary
> Arrg, why does flameeyes keep pushing these OS-specific hacks? If it
> were windows brain damage someone were trying to work around we would
> just tell them to piss off, but since it's GNU brain damage everyone
> keeps entertaining his broken solutions... IMO we should treat all
> brain damage the same. If shared libs are this broken then *gasp*
> don't use shared libs!

It's not shared libs that are broken; it's C++.  We don't have a problem
with conflicting symbols, so we don't need a solution either.  I will not
be committing any build system changes related to this before seeing evidence
of a real problem.

M?ns Rullg?rd
mru at inprovide.com

More information about the ffmpeg-devel mailing list