[Ffmpeg-devel] [PATCH] Redefine NAN in eval.c

Christian Iversen chrivers
Sat Sep 23 00:24:25 CEST 2006


On Saturday 23 September 2006 00:04, Reimar D?ffinger wrote:
> Hello,
>
> On Fri, Sep 22, 2006 at 11:35:36PM +0200, Panagiotis Issaris wrote:
> > The attached patch, defines NAN -if not already defined as f.e. in C99-
> > to be sqrt(-1) in the scope of eval.c. Regression tests succeed.
>
> Isn't 0.0f/0.0f used normally? That looks less ugly to me than sqrt(-1),

FWIW, I second that. With all the uses of "i" in the math behind signal 
processing, this could mislead people reading it into thinking some form of i 
should be used, when in fact NaN is what is wanted.

Is that a stretch?

-- 
Regards,
Christian Iversen




More information about the ffmpeg-devel mailing list