[Ffmpeg-devel] [PATCH] drawtext.c: 01 fix compiler warnings

Gustavo Sverzut Barbieri barbieri
Sat Sep 23 18:16:12 CEST 2006


On 9/12/06, Michael Niedermayer <michaelni at gmx.at> wrote:
> Hi
>
> On Sun, Sep 10, 2006 at 02:00:02PM -0300, Gustavo Sverzut Barbieri wrote:
> > This is the first patch of a series of incremental patches to drawtext.c.
> >
> > it fix the compiler warnings found in SVN, it's basically signess of
> > datatypes.
> [...]
> > -  unsigned char *text = ci->text;
> > +  char *text = ci->text;
> [...]
> > +          unsigned char previous = text[i - 1];
> >            FT_Get_Kerning( ci->face,
> > -                          ci->glyphs_index[ text[i-1] ],
> > +                          ci->glyphs_index[previous],
>
> this is ugly IMHO

so, any other objection? I use "previous" to avoid a cast in order to
avoid compiler warnings.

-- 
Gustavo Sverzut Barbieri
--------------------------------------
Jabber: barbieri at gmail.com
   MSN: barbieri at gmail.com
  ICQ#: 17249123
 Skype: gsbarbieri
Mobile: +55 (81) 9927 0010
 Phone:  +1 (347) 624 6296; 08122692 at sip.stanaphone.com
   GPG: 0xB640E1A2 @ wwwkeys.pgp.net




More information about the ffmpeg-devel mailing list