[Ffmpeg-devel] [PATCH] Ratecontrol does not check for failure of ff_eval

Panagiotis Issaris takis.issaris
Sun Sep 24 13:12:49 CEST 2006


On zo, 2006-09-24 at 13:02 +0200, Michael Niedermayer wrote:
> > The attached patch handles failure in the ratecontroller in case ff_eval
> > failed. It does so, by reverting to the default rc_eq in case an invalid
> > one is specified. Regression tests succeed.
> rejected, if the user sets invalid parameters then simply doing something
> "random" is not ok the user might end up wasting many hours encoding just to
> realize that ffmpeg "silently" ignored his parameter which had a typo in it
Hm. Okay, but that was why I used log level AV_LOG_ERROR.

Furthermore, exiting seems not an option either, does it? As it is a
library, it would mean any using function would not be able to handle
the failing behavior as it wants to, but will just exit...

I'd think propagating the error would be the best thing to do, so the
calling application can handle the error as it pleases. Would a patch
propagating the NAN upwards be okay?

With friendly regards,

More information about the ffmpeg-devel mailing list