[Ffmpeg-devel] ID3v2

[Rich Felker]

On Sun, Sep 24, 2006 at 01:21:40PM +0200, Andreas ?man wrote:
> Hi
> 
> I've written a tentative patch that adds ID3v2.[234] reading
> and ID3v2.4 writing to the mp3 (de)muxer. I've tested it
> together with xmms and itunes.
> I'd say the primary reasons for using ID3v2 is:
> 
> * It's located at the beginning of the file
>   (obviously a benefit when streaming)
> * It supports strings > 30 chars
> 
> Comments welcome.

This had better be secure. Almost every historical implementation of
id3v2 was full of vulns. That's why rather than supporting it in the
mplayer demuxer I specifically made it skip id3v2.

Id3v2 also has some stupid things like being able to store arbitrary
binary data that might emulate mpeg startcodes. They used to allow
(but not require) it to be escaped to prevent startcode emulation, but
now the escaping is deprecated... :(

I don't object to a working implementation. Just be sure you get it
right.. :)

Rich