[Ffmpeg-devel] [PATCH] fix get_bits_long with ALT_BITSTREAM_READER_LE

[Michael Niedermayer]

Hi

On Tue, Sep 26, 2006 at 12:19:18AM +0200, Reimar D?ffinger wrote:
> Hello,
> On Tue, Sep 26, 2006 at 12:06:39AM +0200, Michael Niedermayer wrote:
> > [...]
> > >  // shamelessly copied from shorten.c
> > >  static int inline get_le16(GetBitContext *gb)
> > >  {
> > > -    return bswap_16(get_bits_long(gb, 16));
> > > +    return get_bits_long(gb, 16);
> > >  }
> > 
> > id suggest to replace get_le16 by get_bits(16)
> > 
> > >  static int inline get_le32(GetBitContext *gb)
> > >  {
> > > -    return bswap_32(get_bits_long(gb, 32));
> > > +    return get_bits_long(gb, 32);
> > >  }
> > 
> > id suggest to replace get_le32 by get_bits_long(32)
> 
> I would have suggested that in a separate patch since it is somewhat cosmetic,
> or do you prefer it to be done in one patch?

iam always in favor of spliting patches if its possible ... my comments
shouldnt have meant that i want this in the same commit, though i would
not mind if it is commited together ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is