[Ffmpeg-devel] [PATCH] Use ff_eval for AVOption parsing

[Panagiotis Issaris]

Hi,

On wo, 2006-09-27 at 14:57 +0200, Michael Niedermayer wrote:
> On Wed, Sep 27, 2006 at 10:47:57AM +0200, Panagiotis Issaris wrote:
> [...]
> > > > 
> > > > Should I have put this (in mpegvideo.h):
> > > >  994 double ff_eval(char *s, double *const_value, const char **const_name,
> > > >  995                double (**func1)(void *, double), const char **func1_name,
> > > >  996                double (**func2)(void *, double, double), char **func2_name,
> > > >  997                void *opaque);
> > > > 
> > > > Within this too?
> > > > #if LIBAVCODEC_VERSION_INT < ((51<<16)+(16<<8)+0)
> > > > ...
> > > > #endif
> > > 
> > > yes probably
> > > well actually the whole ff_eval doesnt belong into mpegvideo.h ...
> > A separate eval.h containing just ff_eval/ff_eval2?
> 
> yes (though somehow i hate these 2 line headers ... especially the ones with
> additional 50 lines of license text)
OK. I'm sending a patch for this in a top-post in a second. It will have
20 lines of header though... :)

With friendly regards,
Takis