[Ffmpeg-devel] [PATCH] vorbis.h -> vorbis_data.c

[Michael Niedermayer]

Hi

On Sat, Sep 30, 2006 at 06:27:16PM +0300, Oded Shimon wrote:
> On Sat, Sep 30, 2006 at 05:15:51PM +0200, Michael Niedermayer wrote:
> > Hi
> > 
> > On Sat, Sep 30, 2006 at 06:09:02PM +0300, Oded Shimon wrote:
> > > It would be silly for me to send this as a patch, because it's an almost 
> > > completely unreadable ~260kb patch. These are the changes to be made:
> > > 
> > > 1. the attached patch, for Makefile and vorbis.c
> > 
> > nothing is attached ...
> 
> sorry :)
> 
> > > 2. vorbis.h would be changed to what is attached below
> > > 3. vorbis_data.c would be svn-cp'ed from vorbis.h, having the 
> > > struct/typedefs removed, and a single line added:
> > > 
> > > const float * ff_vorbis_vwin[8] = { vwin64, vwin128, vwin256, vwin512, vwin1024, vwin2048, vwin4096, vwin8192 };
> > > 
> > > 
> > > I'll commit tommorrow, this is first step for me making vorbis_enc clean 
> > > enough to commit to lavc...
> > 
> > iam against it, moving stuff from 1 file to another leads to a 0k patch
> > not a 260k one, diff the files relative to their correctly matching
> > counterparts, that could also be an empty file if not a single line
> > is matching
> 
> ok, Here's the patch between (the current) vorbis.h, and vorbis_data.c , 
> and yes it's a small patch.
> 
> however, the patch between the current vorbis.h and the one I'm attaching 
> here again, is an uninteresting 130kb one of all the tables being removed.
> 
> So, again:
> 1. the attacked patch for makefile and vorbis.c
> 2. vorbis.h to what is attached below
> 3. vorbis_data.c from vorbis.h and the attached patch for it
> 
> made 2 changes as Mans and Denes requested, the structs stay in vorbis.h

looks ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In the past you could go to a library and read, borrow or copy any book
Today you'd get arrested for mere telling someone where the library is