[Ffmpeg-devel] BlackFin lowlevel pixel operations PATCH

[Marc Hoffman]

Diego Biurrun writes:
 > On Sun, Apr 01, 2007 at 09:37:11PM -0400, Marc Hoffman wrote:
 > > Diego Biurrun writes:
 > >  > On Sun, Apr 01, 2007 at 04:36:26PM -0400, Marc Hoffman wrote:
 > >  > 
 > >  > One more question:
 > >  > 
 > >  > > --- bfin/dsputil_bfin.c	(revision 8581)
 > >  > > +++ bfin/dsputil_bfin.c	(working copy)
 > >  > > @@ -18,38 +21,296 @@
 > >  > >  
 > >  > > +#if 0
 > >  > > +void pblk (uint8_t *p, int w, int h, int s)
 > >  > >  {
 > >  > > +    int i,j;
 > >  > > +    av_log (0,0,"0x%08x:\n", p);
 > >  > > +    for (i = 0;i<h;i++) {
 > >  > > +        for (j=0;j<w;j++)
 > >  > > +	  av_log (0,0,"%3d ", p[j]);
 > >  > > +	p+=s;
 > >  > > +	av_log (0,0,"\n");
 > >  > > +    }
 > >  > > +    av_log (0,0,"\n");
 > >  > >  }
 > >  > > +#endif
 > >  > 
 > >  > What for?  And why the unintuitive name?
 > > 
 > > This is just a debug tool that prints a block of memory, I guess I got
 > > very use to it and thats why the strange name p for print blk for
 > > block.  Nothing to smart at all.  
 > 
 > Oh, come one, are you afraid your keyboard might wear out? :)
 > 
 > Please just call it print_block.
 > 
 > I've removed it for now, we generally take a dim view of #if 0 blocks in
 > FFmpeg.

Thats fine, actually not a problem now that its in existance I use the
.gdbinit to dump these types of things.  Which is better anyways.

How about we add this to the environment?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: gdbi.p0
Type: text/x-patch
Size: 2744 bytes
Desc: gdbinit
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070403/ad32e173/attachment.bin>