[Ffmpeg-devel] [PATCH] THP PCM decoder (GSoC Qualification)

[Diego Biurrun]

On Tue, Apr 03, 2007 at 08:59:31PM +0200, Marco Gerards wrote:
> Michael Niedermayer <michaelni at gmx.at> writes:
> 
> >> --- libavcodec/allcodecs.c	(revision 8605)
> >> +++ libavcodec/allcodecs.c	(working copy)
> >> @@ -242,6 +242,7 @@
> >>      REGISTER_ENCDEC (ADPCM_SWF, adpcm_swf);
> >> +    REGISTER_ENCDEC (ADPCM_THP, adpcm_thp);
> >
> > ENCDEC ?
> 
> Baptiste said "use CODEC and dummy return -1 to stay in conformance
> with others (see IMA_QT)".  I assumed it also applied to allcodecs.c.
> Should I change this to REGISTER_DECODER?
> 
> >> --- libavcodec/Makefile	(revision 8605)
> >> +++ libavcodec/Makefile	(working copy)
> >> @@ -246,6 +246,8 @@
> >>  OBJS-$(CONFIG_ADPCM_SWF_ENCODER)       += adpcm.o
> >> +OBJS-$(CONFIG_ADPCM_THP_DECODER)       += adpcm.o
> >> +OBJS-$(CONFIG_ADPCM_THP_ENCODER)       += adpcm.o
> >
> > unless you write an ADPCM_THP encoder there shouldnt be
> > a CONFIG_ADPCM_THP_ENCODER ...
> 
> Same as above.  Should I remove this?

Yes of course.  You are registering an encoder when no such thing
exists.  This is a bug.

Diego