[Ffmpeg-devel] [PATCH] fix error croping
Fri Apr 6 04:00:46 CEST 2007
-----BEGIN PGP SIGNED MESSAGE-----
> On Thu, Apr 05, 2007 at 07:40:14PM +0200, Luca Abeni wrote:
> > Hi Limin
> > sorry for the late reply...
> > On Wed, 2007-04-04 at 19:11 +0800, Limin Wang wrote:
> > [...]
> > > OK, I add a field for bytes_per_pixel to fix the issue. Please review the
> > > updated patch again.
> > [...]
> > I think the patch now looks much better. But since it adds a field to
> > the PixFmtInfo structure I think someone else will have to approve it (I
> > do not feel comfortable with the fields is such structure).
> cant the value of the new field be calculated from the existing ones
> ans so the new field be avoided?
I don't know how to calculated from the existing field? One possible is add a
function to get the bytes_per_pixel by its color_type which is the same as
now. In addition I think it's more clear to use bytes_per_pixel to get the
size and line_size in avpicture_fill().
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
-----END PGP SIGNATURE-----
More information about the ffmpeg-devel