[Ffmpeg-devel] [PATCH] Properly disable theora decoder on vp3.c if not requested
Diego 'Flameeyes' Pettenò
Sat Apr 7 23:19:19 CEST 2007
So, again while playing with having xine-lib use FFmpeg's build system,
I found a corner case where FFmpeg doesn't build when the Theora
decoder is disabled by user's request (--disable-decoder=theora) but
VP3 is enabled (--enable-decoder=vp3): the latter will bring in vp3.o,
but it doesn't bring in xiph.o like Theora does, and doesn't actually
disable the theora functions, to this result:
In function `theora_decode_init':
reference to `ff_split_xiph_headers'
Attached patch removes the theora_decoder and the init function, so
that the xiph.o functions are not needed.
To reproduce, just run
configure --disable-decoder=theora --enable-decoder=vp3 --disable-decoder=vorbis --disable-encoders
(disabling vorbis decoder is needed or it would bring xiph.o in again,
while disabling decoders is needed for another little flaw I found that
I'll try to address in another patch).
Diego "Flameeyes" Petten?
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 189 bytes
Desc: not available
More information about the ffmpeg-devel