[Ffmpeg-devel] THP ADPCM overflow fix [PATCH]

Mike Melanson mike
Mon Apr 9 21:17:43 CEST 2007

Marco Gerards wrote:
> Hi,
> There are some cracks when playing some THP files (the samples on the
> website work just fine).  This is because of an underflow/overflow.
> Here is a patch to fix this.

I'm still hearing pops with the problem file, especially notable when 
the cannon fires.

Also, I'm wondering if the CLAMP_TO_SHORT() macro should be deleted and 
replaced with the av_clip() inline function from lavu? It seems that all 
the ADPCM decoders use the first while the encoders all use the last. 
There is probably no good reason for that.

	-Mike Melanson

More information about the ffmpeg-devel mailing list