[Ffmpeg-devel] [bug] raw.c link failure on ff_ac3_parse_header

[Diego Biurrun]

On Tue, Apr 10, 2007 at 09:53:18AM +0100, M?ns Rullg?rd wrote:
> Diego Biurrun <diego at biurrun.de> writes:
> >
> > I'm thinking that it might be cleaner to move ff_ac3_parse_header out of
> > ac3.c and into parser.c where the other parse functions are.  This would
> > save some #ifdefs in ac3.c.
> 
> I'm undecided on the location of these things.  In a way I like to
> keep everything relating to a particular codec together, especially
> when the decoder uses the same functions.  OTOH keeping the parser
> code in one place has its virtues.

Here's an alternative patch that moves the code.  It's slightly more
intrusive since it has to move code around, but it adds only one #ifdef.

I think I prefer this version.

Diego
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ac3_move.patch
Type: text/x-diff
Size: 7282 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070411/cb187c3e/attachment.patch>