[Ffmpeg-devel] [PATCH] DVR-MS probe audio format - was DVR-MS bug (MP2 decoding)

Michael Niedermayer michaelni
Thu Apr 12 00:30:31 CEST 2007


Hi

On Wed, Apr 11, 2007 at 03:09:13PM -0500, John Donaghy wrote:
> >Hi
> >
> >On Wed, Apr 11, 2007 at 12:21:56PM -0500, John Donaghy wrote:
> >> >
> >> >looks good assuming it passes regression tests
> >> >
> >>
> >> As discussed before, the lavf demuxer in libmpdemux will break when
> >> this patch is applied. This is because the codec_tag that is read from
> >> the dvr-ms file's audio stream header is not reliable. ffmpeg doesnt
> >> have a problem with this as long as the codec_id has been set
> >> correctly but the lavf demuxer currently needs the codec_tag to either
> >> be correct, or else set to '0'.
> >>
> >> So, if I change the asf.c code that reads the stream header to the
> >> following it works in both ffmpeg and maplayer:
> >>
> >> get_wav_header(pb, st->codec, type_specific_size);
> >> if (is_dvr_ms_audio) {
> >>    // codec_id is unreliable in dvr_ms files
> >>    // set it later by probing stream
> >>    st->codec->codec_id = CODEC_ID_NONE;
> >>    st->codec->codec_tag = 0;                         // proposed new code
> >> }
> >>
> >> Do you want me to resubmit with this change?
> >
> >ok
> >
> 
> Here it is.

looks ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070412/09a7bce0/attachment.pgp>



More information about the ffmpeg-devel mailing list