[Ffmpeg-devel] [PATCH] TTA Seeking

Michael Niedermayer michaelni
Sat Apr 14 19:39:03 CEST 2007


Hi

On Sat, Apr 14, 2007 at 07:33:43PM +0200, Aurelien Jacobs wrote:
> On Sat, 14 Apr 2007 12:49:12 -0400
> David Conrad <umovimus at gmail.com> wrote:
> 
> > On Apr 14, 2007, at 11:30 AM, Michael Niedermayer wrote:
> > 
> > > Hi
> > >
> > > On Sat, Apr 14, 2007 at 04:44:30PM +0200, Aurelien Jacobs wrote:
> > >> On Fri, 13 Apr 2007 22:33:27 -0400
> > >> David Conrad <umovimus at gmail.com> wrote:
> > >>
> > >>> Hi,
> > >>>
> > >>> The following patch adds support for seeking in TTA files.
> > >>>
> > >>> -David
> > >>>
> > >>> [...]
> > >>>
> > >>> -static int tta_read_close(AVFormatContext *s)
> > >>> +static int tta_read_seek(AVFormatContext *s, int stream_index,
> > >>> int64_t timestamp, int flags)
> > >>>
> > >>> [...]
> > >>>
> > >>> @@ -143,6 +140,7 @@
> > >>>       tta_probe,
> > >>>       tta_read_header,
> > >>>       tta_read_packet,
> > >>> -    tta_read_close,
> > >>> +    NULL,
> > >>
> > >> Removal of tta_read_close is not related to this patch. Thus it  
> > >> should
> > >> go in a separate patch.
> > >
> > > tta_read_close() freed seektable, now seektable is no longer needed  
> > > as the
> > > lavf index code is used
> > >
> > > i agree that switching from seektable to the internal index code could
> > > be a seperate patch from adding seeking support though IMHO i wouldnt
> > > call them unrelated
> > 
> > New patch that only changes from using the seektable to the lavf  
> > index code attached. Also correctly moves the !st check.
> 
> Patch looks fine to me (except for the mime type of the attachement ;-)

it also looks fine to me

and i would have no objections to giving david (and several other students
svn write access to main ffmpeg svn) if the SOC mentors/admins agree?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The misfortune of the wise is better than the prosperity of the fool.
-- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070414/a68c672a/attachment.pgp>



More information about the ffmpeg-devel mailing list