[Ffmpeg-devel] [PATCH] proper fix for AC3 parser linkage

matthieu castet castet.matthieu
Sat Apr 21 21:01:08 CEST 2007


Diego Biurrun wrote:
> Attached is a proper fix for the link failure when disabling the AC3
> encoder while the AC3 parser is still enabled.
> 
> It has the added benefit of removing some extern declarations from
> ac3.h, the diffstat should be quite convincing.
> 
>  3 files changed, 2 insertions(+), 13 deletions(-)
> 
> I'll commit tomorrow if nobody objects.
> 
Hum, this seems broken : now we have ac3tab.h global array declaration 
in ac3.c and parser.c.
And also now these array are duplicated.
That's why I always found ugly to put data declaration and init in 
header file instead of *.c .


Matthieu




More information about the ffmpeg-devel mailing list