[Ffmpeg-devel] [PATCH] proper fix for AC3 parser linkage

Aurelien Jacobs aurel
Sun Apr 22 00:55:30 CEST 2007

On Sat, 21 Apr 2007 21:01:08 +0200
matthieu castet <castet.matthieu at free.fr> wrote:

> Diego Biurrun wrote:
> > Attached is a proper fix for the link failure when disabling the AC3
> > encoder while the AC3 parser is still enabled.
> > 
> > It has the added benefit of removing some extern declarations from
> > ac3.h, the diffstat should be quite convincing.
> > 
> >  3 files changed, 2 insertions(+), 13 deletions(-)
> > 
> > I'll commit tomorrow if nobody objects.
> > 
> Hum, this seems broken : now we have ac3tab.h global array declaration 
> in ac3.c and parser.c.
> And also now these array are duplicated.
> That's why I always found ugly to put data declaration and init in 
> header file instead of *.c .

I agree with this.
The attached patch will move all the tables in ac3tab.c so that only
ac3tab.o is required by parser.o.
Note that to apply this patch you must:
  svn mv libavcodec/ac3tab.h libavcodec/ac3tab.c
  patch -p0 < ac3tab.diff
  svn add libavcodec/ac3tab.h

If this patch is ok, I intend to apply it in several steps.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: ac3tab.diff
Type: text/x-diff
Size: 6877 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070422/48fb822a/attachment.diff>

More information about the ffmpeg-devel mailing list