[Ffmpeg-devel] [RFC] remove support for AMR NB fixed-point

[Diego Biurrun]

On Wed, Apr 25, 2007 at 11:26:10AM +0200, Michael Niedermayer wrote:
> 
> On Wed, Apr 25, 2007 at 10:52:24AM +0200, Diego Biurrun wrote:
> > On Mon, Apr 23, 2007 at 09:18:20PM +0200, Dominik 'Rathann' Mierzejewski wrote:
> > > On Sunday, 22 April 2007 at 21:34, Diego Biurrun wrote:
> > > > On Sun, Apr 22, 2007 at 03:04:25PM +0200, Michael Niedermayer wrote:
> > > > > 
> > > > > On Sun, Apr 22, 2007 at 02:53:49PM +0200, Diego Biurrun wrote:
> > > > > > I would like to remove support for AMR NB, fixed-point version.
> > > > > > 
> > > > > > The feature is non-essential, we have support for the floating-point
> > > > > > version.
> > > > > > 
> > > > > > The support we currently have is extremely hackish, external source code
> > > > > > needs to be imported into FFmpeg.  For AMR NB floating-point version
> > > > > > there now exist proper libraries.  Removing support might motivate
> > > > > > somebody to do this for the fixed-point version as well.
> > > > > > 
> > > > > > Furthermore, the AMR libraries are non-free.  
> > > > > 
> > > > > do you have a link to their license/copyright?
> > > > 
> > > > I don't have a link.  I just spent some time unsuccessfully looking for
> > > > them.  Maybe somebody else can shed a light?
> > > > 
> > > > > and/or summary of why they re non free (i never read their license
> > > > > aterms ...)
> > > > 
> > > > I was operating under the assumption that AMR did not allow
> > > > redistribution.  No licensing terms means no distribution
> > > > rights at all in any case.
> > > 
> > > There is a MS Word document included with the sources which says that (more
> > > or less) redistribution is prohibited without written permission.
> > > 
> > > [...]
> > >     No part may be reproduced except as authorized by written permission.
> > >   The copyright and the foregoing restriction extend to reproduction in all
> > >                                    media.
> > >                                          
> > >    ? 2004, 3GPP Organizational Partners (ARIB, CCSA, ETSI, T1, TTA, TTC).
> > >                             All rights reserved.
> > > [...]
> > 
> > Thanks.
> > 
> > So what do the others think?  Can I remove this ugly wart from FFmpeg's
> > pretty face? :)
> 
> yes

I removed it from the build system and documentation.  Should we remove
the relevant parts from libavcodec/amr.c as well or keep them?

Diego