[Ffmpeg-devel] PATCH: swscale-example
Thu Apr 26 17:04:26 CEST 2007
Marc Hoffman wrote:
> M?ns Rullg?rd writes:
> > Diego Biurrun wrote:
> > > On Wed, Apr 25, 2007 at 07:36:30AM -0400, Marc Hoffman wrote:
> > >>
> > >> Also the build system seem'd to be broken for me as my
> > >> system doesn't know how to make a -lm file. Is this build patch
> > >> acceptable?
> > >>
> > >> --- libswscale/Makefile (revision 23112)
> > >> +++ libswscale/Makefile (working copy)
> > >> @@ -18,7 +18,8 @@
> > >>
> > >> -swscale-example: swscale-example.o $(LIB) -lm
> > >> +swscale-example: swscale-example.o $(LIB)
> > >> + $(CC) $(CFLAGS) -o $@ $< $(LIB) ../libavutil/libavutil.a -lm
> > >
> > > Curious, what's the exact error message?
> > The old version is definitely wrong. You can't put -lm in the
> > prerequisites list. However, I'd prefer $^ instead of $< $(LIB).
> > The patch also adds libavutil.a which wasn't there at all previously.
> > This change is probably correct. I don't know offhand whether
> > swscale-example uses lavu.
> I believe the link line is now perfect for this test infastructure.
Define "now". The checked-in version is wrong, and your suggestion can
be improved. I don't see how that's in way perfect.
mans at mansr.com
More information about the ffmpeg-devel