[Ffmpeg-devel] [PATCH] FAAC profile selection

Michael Niedermayer michaelni
Sun Apr 29 13:32:54 CEST 2007


On Sun, Apr 29, 2007 at 12:53:03PM +0200, Nicolas George wrote:
> Le nonidi 9 flor?al, an CCXV, Michael Niedermayer a ?crit?:
> > iam not disagreeing with your argumentation but i prefer the simplest/most
> > minimal code which gets the job done optimally and theres no real gain with
> > the #ifdef IMHO
> > 
> > also various other parts of AVOption are not under #ifdef
> > i mean arithmetic coding, the various mpeg4 options, ...
> > and if they all where under ifdefs the AVOption list would contain 3 times
> > more ifdefs then actual code ...
> That is quite convincing indeed. Here is an updated version of the patch to
> take your remarks into account.

looks ok

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070429/942d2408/attachment.pgp>

More information about the ffmpeg-devel mailing list