[FFmpeg-devel] sdp.c and CONFIG_RTP_MUXER
Thu Aug 2 16:18:48 CEST 2007
On Thu, Aug 02, 2007 at 11:03:27AM +0200, Luca Abeni wrote:
> On Tue, 2007-07-31 at 22:32 +0200, Michael Niedermayer wrote:
> > On Tue, Jul 31, 2007 at 10:19:31PM +0200, Luca Abeni wrote:
> > > BTW, since a third parameter (of type char **) has to be added to
> > > avf_sdp_create(), maybe it makes sense to allocate the buffer in the
> > > caller, changing the prototype to
> > > int avf_sdp_create(AVFormatContext *ac, int n_files, char *buff, int
> > > size)
> > > Let me know your opinion.
> > i think caller allocated buffers are a good idea
> > avoids av_malloc() dependancy and free() vs. av_free() bugs
> Here is a patch fixing the compilation problem and changing the
> avf_sdp_create() interface. Sorry for the delay, but before sending it I
> wanted to test the compilation with different configure options, and to
> check that SDP generation is still working properly.
> If needed, I can commit the patch in two times (the first patch will not
> change the avf_sdp_create() prototype, and will be the
> fix-compilation-with-sdp-3.diff I posted some days ago). Let me know.
looks ok, and yes i slightly prefer 2 commits
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel