[FFmpeg-devel] Proposed patch

Michael Niedermayer michaelni
Sat Aug 4 02:40:43 CEST 2007


On Thu, Aug 02, 2007 at 08:22:02PM -0700, Roman Shaposhnik wrote:
> Guys,
> two questions: 
>    1. Does an attached patch look ok?

this changes one of the most speed critical things in lavc so this needs
extensive benchmarks, x86+ppc mpeg4 decoding at minimum
(more non x86 archs would be very welcome too)
also changing HAVE_FAST_UNALIGNED for negatively affected archs
might prevent the speedloss

>    2. I would like to add AV_ prefix to (LD|ST)(16|32|64) macros from 
>       intreadwrite.h. The question is would it be enough or should
>       we make them more similar to existing AV_(R|W)(B|L)(16|32|64)
>       macros by going:
>                LD(16|32|64) -> AV_R(16|32|64)
>                ST(16|32|64) -> AV_W(16|32|64)

i agree with the AV_ prefix and i dont really have any strong oppinion
on the R/W vs. LD/ST stuff though i would prefer RN/WN for native endian
over R/W

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I know you won't believe me, but the highest form of Human Excellence is
to question oneself and others. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070804/2cd9021d/attachment.pgp>

More information about the ffmpeg-devel mailing list