[FFmpeg-devel] [PATCH] make sure blending the subtitle does not write outside buffer

Michael Niedermayer michaelni
Sun Aug 5 12:50:28 CEST 2007


On Sun, Aug 05, 2007 at 12:36:34PM +0200, Reimar D?ffinger wrote:
> Hello,
> On Sun, Aug 05, 2007 at 12:12:26PM +0200, Michael Niedermayer wrote:
> > On Sun, Aug 05, 2007 at 11:00:04AM +0200, Reimar D?ffinger wrote:
> > > attached patch fixes the subtitle rectangles so they do not lie outside
> > > the video, which can cause crashes.
> > 
> > hmm, this seems like a hack to me
> > shouldnt blend_subrect "skip" the parts of a rectange which are outside
> > of the image?
> well, unfortunately blend_subrect does not currently know the size of
> the image. But more importantly, what is the point of showing half-cut
> subtitles? At least I don't have any use for subtitles where I can read
> e.g. only the upper half.

A. the x/y/w/h of the subtitle is wrong
-> fix the code so its not wrong
B. the x/y/w/h of the subtitle is correct
-> you should display the subtitle at that position

if the video for example is croped then i would argue that the x/y/w/h
of the subtitle is wrong if its not moved to a more appropriate place

but if on a non croped video some subtitle lets say moves off the screen
slowly forcing that to stay on the screen is not correct


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

it is not once nor twice but times without number that the same ideas make
their appearance in the world. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070805/b5c95be7/attachment.pgp>

More information about the ffmpeg-devel mailing list