[FFmpeg-devel] [PATCH] make sure blending the subtitle does not write outside buffer

Michael Niedermayer michaelni
Sun Aug 5 14:56:00 CEST 2007


On Sun, Aug 05, 2007 at 02:25:54PM +0200, Reimar D?ffinger wrote:
> Hello,
> On Sun, Aug 05, 2007 at 01:34:46PM +0200, Michael Niedermayer wrote:
> [...]
> > neither, you need to know these details and place the subs according to
> > how they are supposed to be placed
> > if you really lack all this details then how does a binary player display
> > it properly?
> Sorry, I was sidetracked thinking about the general case, e.g. when
> using extracted/separate subtitles. For XSUB in AVI there is of course a
> proper solution.
> The best practical reasoning I have to offer is that ffplay is mostly
> used for development and it makes things somewhat easier if there is one
> reason less why the subtitle doesn't appear.
> In that light, do you think it would be a good/acceptable idea to make
> ffplay display subtitles by default? Because currently to show any in
> the sample I need to press 't' to enable them and then seek to the very
> beginning, and even then sometimes not all are show, because the data is
> in the very first packets which are not placed in the subtitle queue
> unless playing really from the very start.

i ve no real oppinion about displaying or not displaying subs by default
but they definitly should be displayed properly when seeking ...
also we should fix all out of array writes before enabling sub display
by default ...

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Complexity theory is the science of finding the exact solution to an
approximation. Benchmarking OTOH is finding an approximation of the exact
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070805/93a97320/attachment.pgp>

More information about the ffmpeg-devel mailing list