[FFmpeg-devel] [PATCH] Codec lookup: do not use codec_id

Michael Niedermayer michaelni
Mon Aug 6 02:54:59 CEST 2007


On Sun, Aug 05, 2007 at 09:51:11PM +0200, Nicolas George wrote:
> Hi.
> L'octidi 18 thermidor, an CCXV, Michael Niedermayer a ?crit?:
> > i think setting video_stream_copy and video_codec_name here is clearer than
> > a call to opt_video_codec() also its a more minimalistic change relative to
> > the current code
> I agree. I went through the opt_*_codec functions because of the av_free,
> but the av_free is no longer there.
> I also complied with the other stylistic remarks, although I feel this
> coding style quite unnatural.
> Here the updated version of the patch. Again, it passes the same series of
> tests as the previous versions.
> Suggested log message:
> Use the codec name from the command line options instead of the codec id.

patch looks ok

> PS: A small question for later patches: would an attached file be preferred?

attached is preferred

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070806/97586ecb/attachment.pgp>

More information about the ffmpeg-devel mailing list