[FFmpeg-devel] [PATCH] fix post r9988 Cygwin builds
Ramiro Ribeiro Polla
Sun Aug 12 03:40:50 CEST 2007
> Ramiro Polla <ramiro at lisha.ufsc.br> writes:
>> use_winsock2.diff makes network.h check if winsock2 is to be used.
> I still don't see why you're doing it like this. Why not just replace
> #ifdef HAVE_WINSOCK2_H with #ifdef HAVE_ARPA_INET_H and swap the sides
> of the else. Since one of the two will be defined if networking is
> enabled, this will accomplish the same thing.
It's not as simple because winsock mostly adds stuff on top of the
normal networking code. Cygwin can't use the winsock code.
Attached patch assumes network either arpa/inet.h or winsock.2, and
It would be best if the fallback from the #ifdef was to normal code,
like in ff_socket_nonblock(). This would the best if Cygwin accepted it:
assume arpa/inet.h and its normal networking code
Attached patch changes to:
assume winsock and its badly designed networking code
Another alternative (presented in a previous patch):
#if !defined(HAVE_ARPA_INET_H) && defined(HAVE_WINSOCK2_H)
arpa/inet.h and its normal networking code
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 2506 bytes
Desc: not available
More information about the ffmpeg-devel