[FFmpeg-devel] [RFC] move wmv2.c to its own file
Mon Aug 13 19:59:11 CEST 2007
On Mon, Aug 13, 2007 at 12:53:06AM +0300, Ivan Kalvachev wrote:
> 2007/8/12, Diego Biurrun <diego at biurrun.de>:
> > On Sat, Aug 11, 2007 at 07:00:19PM +0300, Ivan Kalvachev wrote:
> > > 2007/8/11, Diego Biurrun <diego at biurrun.de>:
> > > > On Sat, Aug 11, 2007 at 04:29:59PM +0200, Aurelien Jacobs wrote:
> > > > > On Sat, 11 Aug 2007 15:58:34 +0200
> > > > > Diego Biurrun <diego at biurrun.de> wrote:
> > > > > >
> > > > > > New patch attached. OK to commit?
> > > > >
> > > > > This one looks ok to me.
> > > >
> > > > OK, wonderful, I'll commit after the weekend unless I hear objections.
> > >
> > > I'm not sure that this is the whole patch.
> > > Please provide the whole patch.
> > >
> > > The current patch removes msmpeg4tab.h from the only file that uses it
> > > - msmpeg4.c. It doesn't add it anywhere, doesn't change it to .c and
> > > doesn't make its content available in any other way.
> > > There are lines that add extern-s for the tables, but the tables are
> > > not accessible.
> > >
> > > The tables in msmpeg4tab.h are not touched and are still declared as
> > > static, if they are just copy/pasted to msmpeg4data.c, it would create
> > > some problems...
> > Please read the whole thread before commenting.
> I'm not going to guess what you are intending to commit based on your
> previous broken patches.
> It would take you less than 5 minutes to make and post new complete
> patch. It never hurts to be extra careful.
> Please send the complete patch you are intending to commit.
Review the patch on -cvslog, I just committed.
The tables are copy-pasted, prettyprinted and the ones declared in the
header file are made non-static. I did as Aurelien told me, it compiles
and passes regression tests. I'm quite confident I did this right.
More information about the ffmpeg-devel