[FFmpeg-devel] [PATCH] Use the SDP generator in ffmpeg and ffserver

[Michael Niedermayer]

Hi

On Mon, Aug 13, 2007 at 03:43:59PM +0200, Luca Abeni wrote:
> Hi Michael,
> 
> Michael Niedermayer wrote:
> [...]
> >> Is the behaviour of ffmpeg_use_sdp_generator.diff ok? (would it be better 
> >> to introduce a new command line option for generating an SDP? Would it be 
> >> useful to generate an SDP even if the output is not RTP? ...) I implemented 
> >> the behaviour that is more useful to me, but if anyone has suggestions I'll 
> >> happily modify the patch.
> > 
> > no clue, id say a command line option which takes a file name and uses '-'
> > for stdout might be best
> 
> Ok. Is it ok to first commit ffmpeg_use_sdp_generator.diff and then 
> implement an "-sdpfile" command line option with a second patch?

commit it in whichever way and order is cleanest ...


> 
> 
> > [...]
> >> +    if (stream->title[0] != 0) {
> >> +        strcpy(avc->title, stream->title);
> > 
> > av_strlcpy()
> 
> Ok. I fixed it in my local copy. BTW, I notice there are some "strcpy()" 
> in ffmpeg.c and ffserver.c. Should they be removed? If yes, I'll try to 
> submit patches for this in the next weeks.

the ones copying between the same fields in different instances of the same
struct are relatively safe though i would replace them as well just to be
safe from the case that they arent properly null terminated ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Democracy is the form of government in which you can choose your dictator
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070814/30db9811/attachment.pgp>