[FFmpeg-devel] Extension of pipe url

Måns Rullgård mans
Wed Aug 15 14:49:07 CEST 2007

Vincent Fourmond wrote:
> M?ns Rullg?rd wrote:
>> Vincent Fourmond wrote:
>>> M?ns Rullg?rd wrote:
>>>> And indentation style should be consistent and sane.  That is, GNU style
>>>> is not tolerable.
>>>   OK, thanks. Does that look better now ?
>> The indentation style is still inconsistent.
>> Furthermore, IMO you should treat things like "10abc" as non-numeric too,
>> and not only reject strings not starting with a digit.  This is easily
>> done as if(*final) since strtol() will set the end pointer pointing at
>> the null terminator if the string is all digits.
>   Yep... You still need the filename == final check to avoid matching
> 'pipe:'.

Yes, I suppose that's as good a way as any to check for that.

> Here it is, stripped of the last remaining tabs ;-).

Your brace placement is inconsistent, and you're still reindenting
existing code contrary to what Michael told you.

M?ns Rullg?rd
mans at mansr.com

More information about the ffmpeg-devel mailing list