[FFmpeg-devel] [PATCH] mp3 format duration estimate broken

Michael Niedermayer michaelni
Sat Aug 18 21:55:46 CEST 2007


On Sat, Aug 18, 2007 at 08:33:29PM +0200, Andreas ?man wrote:
> Hi
> After r10138 (i believe, didnt test), lavf can no longer estimate
> duration of mp3 files.
> Attached patch should remedy that

the bug is in libavformat/utils.c
there even is a patch which likely would fix it, its just full of tabs

me makes note, if someone posts a patch to fix a bug without explainging
why the buggy behavior arises and how the patch prevents that and for
regressions why a specific change broke things
then more likely than not the patch is wrong

also if the fix changes a variable apparently unrelated to the problem
that as well is no good sign

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Everything should be made as simple as possible, but not simpler.
-- Albert Einstein
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070818/0ab44ea5/attachment.pgp>

More information about the ffmpeg-devel mailing list